• Previous message: [greg-dev] FireStats
  • Next message: [greg-dev] Determining item uniqueness
  • Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

    [greg-dev] Determining item uniqueness

    I'm not sure I agree with the way gregarius determines if an item is
    unique for the purposes of updating/adding.
    
    It makes it's decision here (util.php):
    $sql = "select id,length(description),unread from ".getTable("item")."
    where cid=$cid and url='$url' and title='$dbtitle'";
    
    So, it decides based on url, title, and cid.
    
    I've seen feeds change the url of items, unfortunately. Particularly
    feeds coming from message boards.
    
    Most of the feeds that do this have a guid field though, fortunately.
    
    So, I think there should be 2 cases ...
    check for guid first, then check for url, cid, title.
    
    Checking for guid first (and allowing updating), will prevent 2
    headlines from these nasty feeds that change their item url's.
    
    Also, guid is not always a permalink. Only if the attribute isPermalink
    is set to 'true'. Using guid for url can be dangerous.
    
    -- 
    Lonely is a man without love.
    		-- Englebert Humperdinck
    
    Posted by e-head [reply] at Wed Oct 11 23:08:20 CEST 2006