[greg-dev] some feedback about gregarius

Marco,

1. nav.php template
-------------------

Maybe I am wrong ^^ - I will try to point my view step by step.
All code is taken from the current svn trunk (revision 878)

In the index.php of the current theme (I take the default as example)
there is such code block:

<div id="nav" class="frame">
     <ul class="navlist">
         <?php echo rss_nav_items() ?>
     </ul>
     <?php echo  rss_nav_afternav() ?>
</div>

Especially <?php echo rss_nav_items() ?> calls the wrapper function

function rss_nav_items() {
     $nav = new Navigation();
     foreach ($GLOBALS['rss']->nav->items as $item) {
         $item -> render();
     }
}

There is the navigator-class instance created.
But instead of calling the render function of the navigator instance

(Code taken from Navigator class):

function render()
{
	rss_require(RSS::getTemplateFile("nav.php"));
}

it iterates over the items and class there render function.

(Code taken from NavItem class):

function render()
{
         $GLOBALS['rss'] -> currentNavItem = &$this;
         rss_require(RSS::getTemplateFile("navitem.php"), false);
}

So the Navigator - render function is not called - although the nav.php 
template in the theme contains the wrapper function call for the items.

(Code taken from theme/default/nav.php):

<ul class="navlist">
<?php echo  rss_nav_items() ?>
</ul>

A small fix would be something like this:

http://sinless.org/pipermail/gregarius-dev/2005-September/000481.html

The theme/default/index.php then must look like this:

<div id="nav" class="frame">
     <ul class="navlist">
         <?php echo rss_nav() ?>
     </ul>
     <?php echo  rss_nav_afternav() ?>
</div>

This would call the wrappers/nav.php -> rss_nav() function, which
would call the Navuigator -> render() function.
The theme/default/nav.php template would be integrated, which calls the 
rss_nav_items() wrapper function.

When I look back to the top of this mail - I am not really sure I could 
put into words / characters what I meant :-( Hope its not to confusing.
Therefore I will discuss the other points later on.

best regards.

>>>1. nav.php template
>>>-------------------
>>>
>>>in the index.php there is a function call rss_nav_items(), which calls
>>>the wrapper function rss_nav_items(), which creates a new instance of
>>>Navigator and renders the items. So the nav.php template will be
>>>needless. It's never called. So I implemented a new function
> 
> 
> Hmm, I'm not sure if this changed since 0.5.0, but in 0.5.1 this
> doesn't seem to work this way. In fact it looks like both the template
> files (nav and navitem.php are called)
> 
> Am I wrong or am I missing something?
> 
> 
> 
>>>2. navigation class
>>>------------
>>>
>>>the constructor adds by default some navitems to its list.
>>>for the devlog its customizable by config - it would be great to do so
>>>for the other navitems.
>>>
> 
> 
> Yes, thats a nice idea. I'll have to think of a smart way to implement
> this though (one configuration entry per button is not an option, in
> my opinion)
> 
> 
> 
>>>3. taglist.php
>>>--------------
>>>
>>>the function render() contains the template - therefore it is not
>>>possible to change the style - a template would be appreciated :-)
>>>
> 
> 
> That's a good point. I create http://svn.gregarius.net/trac/ticket/172
> to track this issue.
> 
> 
> 
>>>4. private feeds
>>>----------------
>>>
>>>if i mark some feeds as private and they have new items - these new
>>>items are shown index. but not the feeds. I guess this could be a bug -
>>>maybe someone can doublecheck?
>>>
> 
> 
> Can't reproduce this, I think it was fixed since 0.5.0 was released.
> 
> 
>>>If there are more things I think they are worse mentioning - I hope it
>>>will be appreciated to post them here.
>>>
>>>If you could need a helping hand on development - just let me now - I
>>>would be very pleased to contribute.
>>>
> 
> 
> Help is always appreciated! If you spot anything that looks
> interesting in the bugslist ( http://svn.gregarius.net/trac/report/3 )
> feel free to give it a try :)
> 
> Thank you for your feedback,
> 
>  -m
> 
> _______________________________________________
> gregarius-dev mailing list
> gregarius-dev at sinless.org
> http://sinless.org/mailman/listinfo/gregarius-dev