Marco, I would favour a javascript approach. It would solve a,b,c, and d. a). I agree that ratings should be read-only for non-admins. The javascript code would only be sent out if you are logged in and this code will call a function in the php code to actually set the rating. This code should also check to see that we are logged in. b). The new system would use minimal css, so that we can place the rating box anywhere we like. Right now it is quite hard to place the rating box inline with something else. c). I am not sure there would be less markup, but it would definitely be less than or equal to. We could reduce the markup, if we made it two clicks. One click to call a function to show the rating system and one to make the rating. I would rather avoid two clicks as it becomes painful while rating lots of items. It is my opinion that if the markup is similar, then it will compress well and since most of our browsers support gzip there will be negligble increase in bandwidth. d). Klar. Sameer On Tue, Sep 13, 2005 at 06:47:01PM +0200, Marco Bonetti wrote: > Date: Tue, 13 Sep 2005 18:47:01 +0200 > From: Marco Bonetti <mbonetti at gmail.com> > To: gregarius-dev at sinless.org > Subject: [greg-dev] Thoughts on rating system > Reply-To: mbonetti at gmail.com, gregarius-dev at sinless.org > > Hello, > no, I'm not dead, I've been thinking and working on the rating system, > and was hoping I could some advice from you folks. > > Here is what is bothering me: > > a) Logic. What should non-admins see? Ideally I'd like to mimic the > tagging policy, e.g. show a read-only rating for items that have been > rated, nothing at all on the others. The problem here is that the > current implementation doesn't offer a simple way to render a > read-only rating. > > b) CSS. The current implementation uses a very ugly CSS hack to > display the stars next to the "Rating" label. This breaks horribly on > non-English locales (just try and switch to German to see what I mean) > > c) Markup. The current implementation downloads a s***load of markup > for every item. > > d) License. I'm not sure the original author actually released his > code under a "public" license. [ > http://komodomedia.com/blog/index.php/2005/08/24/creating-a-star-rater-using-css/ > ] > > > Possible solutions: > > - move the rating system to the dynamic item-editing dialog. This > would fix c) and possibly b) but would hide the rating from non-admins > and require an additional click to rate items. > > - find a whole new implementation, maybe more javascript than CSS > based. Could possibly resolve c) and probably b) > > > What are your thoughts on this? > Thanks, > > -m > > _______________________________________________ > gregarius-dev mailing list > gregarius-dev at sinless.org > http://sinless.org/mailman/listinfo/gregarius-dev